Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

fix: the issue that the useSlugify hook may cause the value to be undefined #884

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 24, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

修复新建分类和标签之后再次打开表单,别名显示为 undefined 的问题。

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3382

Special notes for your reviewer:

测试方式:

  1. 新建分类或者标签,创建完成之后再次打开创建表单,检查别名是否还为 undefined。

Does this PR introduce a user-facing change?

修复 Console 端新建分类和标签之后再次打开表单,别名显示为 undefined 的问题。

@vercel
Copy link

vercel bot commented Feb 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 24, 2023 at 6:47AM (UTC)

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 24, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and QuentinHsu February 24, 2023 06:18
@ruibaby ruibaby added this to the 2.3.x milestone Feb 24, 2023
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, LIlGG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 9490364 into halo-dev:main Feb 24, 2023
@ruibaby ruibaby deleted the fix/slug-undefined branch February 24, 2023 07:19
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 24, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this pull request Mar 2, 2023
…efined (halo-dev/console#884)

#### What type of PR is this?

/kind bug

#### What this PR does / why we need it:

修复新建分类和标签之后再次打开表单,别名显示为 undefined 的问题。

#### Which issue(s) this PR fixes:

Fixes halo-dev#3382

#### Special notes for your reviewer:

测试方式:

1. 新建分类或者标签,创建完成之后再次打开创建表单,检查别名是否还为 undefined。

#### Does this PR introduce a user-facing change?

```release-note
修复 Console 端新建分类和标签之后再次打开表单,别名显示为 undefined 的问题。
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

创建文章标签的别名表单项出现了 undefined
3 participants