Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the theme from freemarker to thymeleaf #119

Open
wants to merge 45 commits into
base: next
Choose a base branch
from

Conversation

L-fw
Copy link

@L-fw L-fw commented Apr 7, 2023

大致完成了首页,分类页,归档页,标签页和文章页的转换,可能还有大大小小的问题,后面会进一步改进。

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Apr 7, 2023

@L-fw: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Apr 7, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Apr 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby
Copy link
Member

ruibaby commented Apr 17, 2023

感谢参与移植,在 Review 前希望先处理这几个问题:

  1. 恢复与迁移无关的文件,比如 README.md、.gitignore、package.json 等。
  2. 恢复 src 目录以及构建方式,目前观察到仅提供了 templates/assets/dist 构建产物,但丢失了源文件,后续可能无法继续维护,这些构建流程与模板迁移无关。
  3. 希望添加 prettier 并格式化所有模板,可以参考:https://github.com/halo-dev/theme-modern-starter

@ruibaby
Copy link
Member

ruibaby commented Apr 18, 2023

image

文章内容中的列表似乎没有列表样式。

@L-fw
Copy link
Author

L-fw commented Apr 18, 2023

OK我看看

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants