Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

主题和插件支持获取 ExternalUrl 配置信息 #2711

Closed
guqing opened this issue Nov 17, 2022 · 1 comment · Fixed by #2714
Closed

主题和插件支持获取 ExternalUrl 配置信息 #2711

guqing opened this issue Nov 17, 2022 · 1 comment · Fixed by #2714
Assignees
@guqing
Labels
area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@guqing
Copy link
Member

guqing commented Nov 17, 2022

Your current Halo version

2.0.0-alpha.4

Describe this feature

目前主题端和插件都获取到 application.yaml 中配置的 halo.external-url 信息
这很必要如 sitemap 插件需要外部访问地址作为 path 的前缀

Additional information

/kind improvement
/area core
/priority critical-urgent
@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. area/core Issues or PRs related to the Halo Core priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Nov 17, 2022
@JohnNiang
Copy link
Member

/assign @guqing

@guqing guqing mentioned this issue Nov 17, 2022
Merged
f2c-ci-robot bot pushed a commit that referenced this issue Nov 18, 2022
@guqing
feat: support obtaining the configuration of halo.external-url for th…
eeb9c4d 
…emes and plugins (#2714)

#### What type of PR is this?
/kind improvement
/area core
/milestone 2.0

#### What this PR does / why we need it:
主题和插件支持获取 `halo.external-url` 配置信息

#### Which issue(s) this PR fixes:

Fixes #2711
#### Special notes for your reviewer:
how to test it?
1. 在主题中使用`<p th:text="${site.url}"></p>` 可以正确显示
2. 在插件中可以依赖注入 ExternalUrlSupplier

/cc @halo-dev/sig-halo 
#### Does this PR introduce a user-facing change?

```release-note
主题和插件支持获取外部访问地址配置
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guqing guqing

Labels
area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support obtaining the configuration of halo.external-url for themes and plugins guqing/halo
2 participants
@JohnNiang @guqing