Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

发现后台配置得自定义页面，不会统计阅读量 #2912

Closed
SimpleDays opened this issue Dec 11, 2022 · 4 comments · Fixed by #2918
Closed

发现后台配置得自定义页面，不会统计阅读量 #2912

SimpleDays opened this issue Dec 11, 2022 · 4 comments · Fixed by #2918
Assignees
@guqing
Labels
area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug.
Milestone
2.0.2

Comments

@SimpleDays
Copy link

是什么版本出现了此问题？

2.0.1

使用的什么数据库？

H2

使用的哪种方式部署？

Docker

在线站点地址

No response

发生了什么？

后台配置自定义页面，比如“关于”页面，前台阅读访问之后，并未统计阅读量

相关日志输出

No response

附加信息

No response
@ruibaby
Copy link
Member

ruibaby commented Dec 11, 2022

可以复现，原因是请求 counter 接口的时候，name 为 null：

image

image

/kind bug
/area core
/milestone 2.1.x

@f2c-ci-robot f2c-ci-robot bot added this to the 2.1.x milestone Dec 11, 2022
@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. area/core Issues or PRs related to the Halo Core labels Dec 11, 2022
@ruibaby
Copy link
Member

ruibaby commented Dec 12, 2022

/assign @guqing

@guqing guqing mentioned this issue Dec 12, 2022
Merged
@JohnNiang
Copy link
Member

Hi @halo-dev/sig-halo，这个 issue 应该放到 2.0.x milestone 吧。

f2c-ci-robot bot pushed a commit that referenced this issue Dec 12, 2022
@guqing
fix: single page does not count visits (#2918)
52906f2 
#### What type of PR is this?
/kind bug
/area core

#### What this PR does / why we need it:
修复自定义页面没有统计访问量的问题
#### Which issue(s) this PR fixes:

Fixes #2912

#### Special notes for your reviewer:
how to test it?
创建自定义页面并到主题端访问，可以看到访问量增加

/cc @halo-dev/sig-halo 
#### Does this PR introduce a user-facing change?
```release-note
修复自定义页面没有统计访问量的问题
```
@JohnNiang
Copy link
Member

/milestone 2.0.x

@f2c-ci-robot f2c-ci-robot bot modified the milestones: 2.1.x, 2.0.x Dec 12, 2022
@JohnNiang JohnNiang modified the milestones: 2.0.x, 2.0.2 Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guqing guqing

Labels
area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
2.0.2
Development

Successfully merging a pull request may close this issue.

fix: single page does not count visits guqing/halo
4 participants
@SimpleDays @JohnNiang @ruibaby @guqing