Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

安装和升级主题如果异常没有明确提示 #2933

Closed
ruibaby opened this issue Dec 13, 2022 · 0 comments · Fixed by halo-dev/console#769
Closed

安装和升级主题如果异常没有明确提示 #2933

ruibaby opened this issue Dec 13, 2022 · 0 comments · Fixed by halo-dev/console#769
Labels
area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement.
Milestone
2.1.0

Comments

@ruibaby
Copy link
Member

ruibaby commented Dec 13, 2022

是什么版本出现了此问题？

2.0.1

使用的什么数据库？

PostgreSQL

使用的哪种方式部署？

Docker Compose

在线站点地址

https://demo.halo.run

发生了什么？

如图，如果主题上传安装或者升级失败，不会提示原因。

image

image

期望 Console 端对其进行适配。

/area console
/kind improvement
/milestone 2.1.x

相关日志输出

No response

附加信息

No response
@f2c-ci-robot f2c-ci-robot bot added this to the 2.1.x milestone Dec 13, 2022
@f2c-ci-robot f2c-ci-robot bot added area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. labels Dec 13, 2022
@ruibaby ruibaby mentioned this issue Dec 13, 2022
Merged
f2c-ci-robot bot pushed a commit to halo-dev/console that referenced this issue Dec 14, 2022
@ruibaby
perf: improve the prompt for upload failure of the upload component (#…
101e91a 
…769)

#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

优化上传组件的异常提示信息。

#### Which issue(s) this PR fixes:

Fixes halo-dev/halo#2933
Ref halo-dev/halo#2932 halo-dev/halo#2931

#### Screenshots:

<img width="794" alt="image" src="https://user-images.githubusercontent.com/21301288/207272593-b94efb0a-7033-4ec1-b1eb-f2e3871b34f0.png">
<img width="674" alt="image" src="https://user-images.githubusercontent.com/21301288/207272682-0c223d29-8c4f-45b0-a8d5-2432a97835c6.png">


#### Special notes for your reviewer:

测试方式：

1. 进入附件上传、插件安装、主题安装界面。
2. 上传不符合规则的文件，比如主题可以上传一个不是主题的 zip 或者 Halo 1.x 版本的 zip。
3. 观察是否有异常提示。

#### Does this PR introduce a user-facing change?

```release-note
优化 Console 端上传组件的异常提示信息。
```
@ruibaby ruibaby modified the milestones: 2.1.x, 2.1.0 Dec 14, 2022
@JohnNiang JohnNiang mentioned this issue Dec 21, 2022
Closed
JohnNiang pushed a commit to JohnNiang/halo that referenced this issue Mar 2, 2023
@ruibaby
perf: improve the prompt for upload failure of the upload component (h…
97d2066 
…alo-dev/console#769)

#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

优化上传组件的异常提示信息。

#### Which issue(s) this PR fixes:

Fixes halo-dev#2933
Ref halo-dev#2932 halo-dev#2931

#### Screenshots:

<img width="794" alt="image" src="https://user-images.githubusercontent.com/21301288/207272593-b94efb0a-7033-4ec1-b1eb-f2e3871b34f0.png">
<img width="674" alt="image" src="https://user-images.githubusercontent.com/21301288/207272682-0c223d29-8c4f-45b0-a8d5-2432a97835c6.png">


#### Special notes for your reviewer:

测试方式：

1. 进入附件上传、插件安装、主题安装界面。
2. 上传不符合规则的文件，比如主题可以上传一个不是主题的 zip 或者 Halo 1.x 版本的 zip。
3. 观察是否有异常提示。

#### Does this PR introduce a user-facing change?

```release-note
优化 Console 端上传组件的异常提示信息。
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement.
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

perf: improve the prompt for upload failure of the upload component ruibaby/halo-console
1 participant
@ruibaby