Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

优化左侧导航栏点击后行为 #3240

Closed
wan92hen opened this issue Feb 7, 2023 · 2 comments · Fixed by halo-dev/console#865
Closed

优化左侧导航栏点击后行为 #3240

wan92hen opened this issue Feb 7, 2023 · 2 comments · Fixed by halo-dev/console#865
Assignees
@ruibaby
Labels
area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement.
Milestone
2.3.0

Comments

@wan92hen
Copy link
Collaborator

wan92hen commented Feb 7, 2023

你当前使用的版本

2.2.0

描述一下此特性

左侧导航栏存在滚动条时，滑动到底部位置点击某个菜单项后，滚动条会自动回到顶部。
建议点击后保持导航栏位置不变。

附加信息

No response
@wan92hen wan92hen changed the title 优化左侧导航栏点击后行为 优化左侧导航栏点击后行为优化 Feb 7, 2023
@wan92hen wan92hen changed the title 优化左侧导航栏点击后行为优化 优化左侧导航栏点击后行为 Feb 7, 2023
@ruibaby
Copy link
Member

ruibaby commented Feb 7, 2023

/kind improvement
/area console

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. area/console Issues or PRs related to the Halo Console labels Feb 7, 2023
@ruibaby ruibaby added this to the 2.3.x milestone Feb 7, 2023
@ruibaby
Copy link
Member

ruibaby commented Feb 20, 2023

/assign

@ruibaby ruibaby mentioned this issue Feb 20, 2023
Merged
f2c-ci-robot bot pushed a commit to halo-dev/console that referenced this issue Feb 21, 2023
@ruibaby
perf: add supports for storing navbar position (#865)
d396337 
#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

支持保存侧板滚动条位置，防止切换路由时侧边栏的抖动。

#### Which issue(s) this PR fixes:

Fixes halo-dev/halo#3240

#### Screenshots:

before:

![2023-02-20 12 12 05](https://user-images.githubusercontent.com/21301288/220007834-12658cf2-e8a8-42ea-93b1-2c58419edbac.gif)


after:

![2023-02-20 12 11 19](https://user-images.githubusercontent.com/21301288/220007742-58471b69-cfd1-4576-babd-5516d2c0de1d.gif)


#### Special notes for your reviewer:

测试方式：

1. 调整浏览器高度，让侧边栏菜单区域出现滚动条。
2. 测试点击底部的任意菜单项，跳转页面之后，观察滚动条是否与之前的位置保持一致。

#### Does this PR introduce a user-facing change?


```release-note
Console 端侧边栏滚动条支持缓存位置，防止切换路由时重置滚动条位置。
```
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 21, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this issue Mar 2, 2023
@ruibaby
perf: add supports for storing navbar position (halo-dev/console#865)
a9331f5 
#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

支持保存侧板滚动条位置，防止切换路由时侧边栏的抖动。

#### Which issue(s) this PR fixes:

Fixes halo-dev#3240

#### Screenshots:

before:

![2023-02-20 12 12 05](https://user-images.githubusercontent.com/21301288/220007834-12658cf2-e8a8-42ea-93b1-2c58419edbac.gif)


after:

![2023-02-20 12 11 19](https://user-images.githubusercontent.com/21301288/220007742-58471b69-cfd1-4576-babd-5516d2c0de1d.gif)


#### Special notes for your reviewer:

测试方式：

1. 调整浏览器高度，让侧边栏菜单区域出现滚动条。
2. 测试点击底部的任意菜单项，跳转页面之后，观察滚动条是否与之前的位置保持一致。

#### Does this PR introduce a user-facing change?


```release-note
Console 端侧边栏滚动条支持缓存位置，防止切换路由时重置滚动条位置。
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruibaby ruibaby

Labels
area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement.
Projects
None yet
Milestone
2.3.0
Development

Successfully merging a pull request may close this issue.

perf: add supports for storing navbar position ruibaby/halo-console
2 participants
@ruibaby @wan92hen