Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

期望 Console 端的 Modal 组件支持设置是否可以点击蒙层以关闭 #3328

Closed
ruibaby opened this issue Feb 16, 2023 · 0 comments · Fixed by halo-dev/console#861
Closed

期望 Console 端的 Modal 组件支持设置是否可以点击蒙层以关闭 #3328

ruibaby opened this issue Feb 16, 2023 · 0 comments · Fixed by halo-dev/console#861
Assignees
@ruibaby
Labels
area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature.
Milestone
2.3.0

Comments

@ruibaby
Copy link
Member

ruibaby commented Feb 16, 2023

你当前使用的版本

2.2.1

描述一下此特性

image

如图，当前 Console 有不少的表单都是以模态框的形式加载的，但目前如果点击模态框的蒙层就会关闭模态框，并且丢失已填写的数据，误操作率比较高。所以期望 Modal 组件支持设置是否可以点击蒙层关闭模态框。

/kind feature
/area console
/milestone 2.3.x

附加信息

No response
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 16, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.3.x milestone Feb 16, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/console Issues or PRs related to the Halo Console label Feb 16, 2023
@ruibaby ruibaby mentioned this issue Feb 16, 2023
Merged
f2c-ci-robot bot pushed a commit to halo-dev/console that referenced this issue Feb 17, 2023
@ruibaby
feat: add layer-closeable prop for modal (#861)
c8dbd24 
#### What type of PR is this?

/kind feature

#### What this PR does / why we need it:

VModal 组件支持设置是否允许点击蒙层以关闭模态框，并将所有包含表单的模态框设置为不允许点击蒙层关闭。

#### Which issue(s) this PR fixes:

Fixes halo-dev/halo#3328

#### Screenshots:

![2023-02-17 12 08 56](https://user-images.githubusercontent.com/21301288/219547318-d7c59742-8546-4bc8-9d49-fcff4053602f.gif)


#### Special notes for your reviewer:

测试方式：

1. 打开 Console 端任意一个表单模态框，测试点击表单外部区域是否会关闭弹框。

#### Does this PR introduce a user-facing change?


```release-note
优化 Console 端部分包含表单的模态框，默认不允许点击外部区域关闭模态框。
```
@ruibaby ruibaby self-assigned this Feb 17, 2023
@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 17, 2023
JohnNiang pushed a commit to JohnNiang/halo that referenced this issue Mar 2, 2023
@ruibaby
feat: add layer-closeable prop for modal (halo-dev/console#861)
11dffce 
#### What type of PR is this?

/kind feature

#### What this PR does / why we need it:

VModal 组件支持设置是否允许点击蒙层以关闭模态框，并将所有包含表单的模态框设置为不允许点击蒙层关闭。

#### Which issue(s) this PR fixes:

Fixes halo-dev#3328

#### Screenshots:

![2023-02-17 12 08 56](https://user-images.githubusercontent.com/21301288/219547318-d7c59742-8546-4bc8-9d49-fcff4053602f.gif)


#### Special notes for your reviewer:

测试方式：

1. 打开 Console 端任意一个表单模态框，测试点击表单外部区域是否会关闭弹框。

#### Does this PR introduce a user-facing change?


```release-note
优化 Console 端部分包含表单的模态框，默认不允许点击外部区域关闭模态框。
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruibaby ruibaby

Labels
area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
2.3.0
Development

Successfully merging a pull request may close this issue.

feat: add layer-closeable prop for modal ruibaby/halo-console
1 participant
@ruibaby