Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version of Spring Boot & SpringDoc #2511

Merged
merged 1 commit into from
Oct 8, 2022
Merged

Bump version of Spring Boot & SpringDoc #2511

merged 1 commit into from
Oct 8, 2022

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind improvement
/area core
/milestone 2.0

What this PR does / why we need it:

  1. Upgrade Spring Boot to 3.0.0-M5. See https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0.0-M5-Release-Notes for more.
  2. Upgrade SpringDoc to 2.0.0-M6. The version is compatible to Spring Boot 3.0.0-M5. See 2.0: auto-configuration broken with Spring Boot 3.0.0-M5 springdoc/springdoc-openapi#1865 for more.

Special notes for your reviewer:

Please check the API documentation endpoint: http://localhost:8090/swagger-ui.html.

Does this PR introduce a user-facing change?

None

@JohnNiang
Bump version of Spring Boot & Springdoc
88a961f 
See springdoc/springdoc-openapi#1865 for more

Signed-off-by: johnniang <johnniang@fastmail.com>
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Oct 6, 2022
@f2c-ci-robot f2c-ci-robot bot added this to the 2.0 milestone Oct 6, 2022
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Oct 6, 2022
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and lan-yonghui October 6, 2022 03:13
@JohnNiang JohnNiang changed the title Bump version of Spring Boot & Springfox Bump version of Spring Boot & SpringDoc Oct 6, 2022
guqing
guqing reviewed Oct 6, 2022
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2022
ruibaby
ruibaby reviewed Oct 6, 2022
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

image

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit b23ed2e into halo-dev:main Oct 8, 2022
@JohnNiang JohnNiang deleted the chore/dependency-upgrade branch October 12, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing left review comments

@ruibaby ruibaby ruibaby left review comments

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

Assignees

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnNiang @ruibaby @guqing