Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running Halo with MySQL and MariaDB database #2512

Merged
merged 1 commit into from
Oct 9, 2022

Conversation

JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Oct 6, 2022

What type of PR is this?

/kind feature
/area core
/milestone 2.0

What this PR does / why we need it:

Add MySQL script to support running Halo with MySQL database due to jasync-sql/jasync-sql#311 has been resolved.

Which issue(s) this PR fixes:

Fixes #2464

Special notes for reviewers

Steps to test:

  1. Start up MySQL. e.g.:

    version: '3.1'
    
    services:
    
      db:
        image: mysql
        # NOTE: use of "mysql_native_password" is not recommended: https://dev.mysql.com/doc/refman/8.0/en/upgrading-from-previous-series.html#upgrade-caching-sha2-password
        # (this is just an example, not intended to be a production configuration)
        command: --default-authentication-plugin=mysql_native_password
        restart: always
        environment:
          MYSQL_ROOT_PASSWORD: openmysql
        ports:
          - 3306:3306
    
      adminer:
        image: adminer
        restart: always
        ports:
          - 8080:8080
    docker-compose -f mysql.yaml up
  2. Start Halo with mysql profile. e.g.:

    ./gradlew bootRun --args="--spring.profiles.active=mysql"
  3. Validate the functionality of Halo

Does this PR introduce a user-facing change?

支持 MySQL 和 Maria DB 作为 Halo 的数据库

Signed-off-by: johnniang <johnniang@fastmail.com>
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 6, 2022
@f2c-ci-robot f2c-ci-robot bot added this to the 2.0 milestone Oct 6, 2022
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Oct 6, 2022
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby October 6, 2022 03:56
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

我这边使用 MariaDB 最新版本测试了下,没有遇到什么问题。

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2022
@JohnNiang
Copy link
Member Author

/retitle Support running Halo with MySQL and MariaDB database

@f2c-ci-robot f2c-ci-robot bot changed the title Support running Halo with MySQL database Support running Halo with MySQL and MariaDB database Oct 9, 2022
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@guqing
Copy link
Member

guqing commented Oct 9, 2022

mysql 测试通过

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit 543bdc4 into halo-dev:main Oct 9, 2022
@JohnNiang JohnNiang deleted the feat/integrate-with-mysql branch October 9, 2022 03:28
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.0 sql文件不支持部署时执行
3 participants