Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add upvote and downvote tracker #2566

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

guqing
Copy link
Member

@guqing guqing commented Oct 13, 2022

What type of PR is this?

/kind feature
/area core
/milestone 2.0
/kind api-change

What this PR does / why we need it:

新增文章和评论等资源的点赞和踩 API

Which issue(s) this PR fixes:

Fixes #2565

Special notes for your reviewer:

how to test it?

  1. 创建并发布一篇文章 替换下面的 your-post-name 然后执行它
curl --location --request POST 'http://localhost:8090/apis/api.halo.run/v1alpha1/trackers/upvote' \
--header 'Content-Type: application/json' \
--data-raw '{
    "group": "content.halo.run",
    "plural": "posts",
    "name": your-post-name
}
  1. 请求成功并得到 response 为点赞数
  2. 踩的 API 为 http://localhost:8090/apis/api.halo.run/v1alpha1/trackers/downvote 请求体与步骤1相同的测试方法
  3. 重启 Halo 后 Counter 数据应该依然存在并且正确

/cc @halo-dev/sig-halo

Does this PR introduce a user-facing change?

新增文章和评论等资源的点赞和踩 API

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 13, 2022
@f2c-ci-robot f2c-ci-robot bot added this to the 2.0 milestone Oct 13, 2022
@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Oct 13, 2022
@guqing guqing force-pushed the feature/upvote-tracker branch from 153fdf7 to 8669882 Compare October 13, 2022 08:41
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2022
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

我将在 theme-default 适配。

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit 08fe185 into halo-dev:main Oct 15, 2022
@guqing guqing deleted the feature/upvote-tracker branch October 15, 2022 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

新增 Upvote 和 Downvote 的 tracker API
3 participants