feat: add an API to list uninstalled themes #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note
f2c-ci-robot
bot
added
area/core
JohnNiang
reviewed
Oct 18, 2022
src/main/java/run/halo/app/core/extension/endpoint/ThemeEndpoint.java
Outdated
Show resolved
Hide resolved
src/main/java/run/halo/app/core/extension/endpoint/ThemeEndpoint.java
Outdated
Show resolved
Hide resolved
JohnNiang
reviewed
Oct 18, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
f2c-ci-robot bot
pushed a commit
to halo-dev/console
that referenced
this pull request
Oct 18, 2022
) #### What type of PR is this? /kind feature /milestone 2.0 #### What this PR does / why we need it: 支持显示和安装**未安装**的主题，以方便主题开发的时候，创建主题资源。适配 halo-dev/halo#2586 #### Which issue(s) this PR fixes: Fixes halo-dev/halo#2554 #### Screenshots: <img width="1663" alt="image" src="https://user-images.githubusercontent.com/21301288/196148567-f43b1bf3-e745-4c1a-950d-65899c1ae73c.png"> #### Special notes for your reviewer: /cc @halo-dev/sig-halo-console 测试方式： 1. 需要 `pnpm install` 2. Halo 需要切换到 halo-dev/halo#2586 PR 的分支。 3. 在本地的 `~/halo-dev/themes` 创建新的主题，需要包含 `themes.yaml`，或者将现有的主题直接下载到 `~/halo-dev/themes` 4. 检查后台主题管理的主题列表中是否显示了未安装的主题，以及测试是否可以安装成功。 #### Does this PR introduce a user-facing change? ```release-note 支持显示和安装未安装的主题，以方便主题开发的时候，创建主题资源。 ```
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
…alo-dev/console#648) #### What type of PR is this? /kind feature /milestone 2.0 #### What this PR does / why we need it: 支持显示和安装**未安装**的主题，以方便主题开发的时候，创建主题资源。适配 halo-dev#2586 #### Which issue(s) this PR fixes: Fixes halo-dev#2554 #### Screenshots: <img width="1663" alt="image" src="https://user-images.githubusercontent.com/21301288/196148567-f43b1bf3-e745-4c1a-950d-65899c1ae73c.png"> #### Special notes for your reviewer: /cc @halo-dev/sig-halo-console 测试方式： 1. 需要 `pnpm install` 2. Halo 需要切换到 halo-dev#2586 PR 的分支。 3. 在本地的 `~/halo-dev/themes` 创建新的主题，需要包含 `themes.yaml`，或者将现有的主题直接下载到 `~/halo-dev/themes` 4. 检查后台主题管理的主题列表中是否显示了未安装的主题，以及测试是否可以安装成功。 #### Does this PR introduce a user-facing change? ```release-note 支持显示和安装未安装的主题，以方便主题开发的时候，创建主题资源。 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/milestone 2.0
/area core
/kind api-change
What this PR does / why we need it:
新增 API 用于查询未安装的主题
Which issue(s) this PR fixes:
Fixes #2554
Special notes for your reviewer:
how to test it?
/cc @halo-dev/sig-halo
Does this PR introduce a user-facing change?