Support configuring Halo in working directory #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note
JohnNiang
added
kind/improvement
|
这个需要改动文档吗？ |
可以用文档描述一下这个功能。 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
|
/cherry-pick release-2.0 |
|
@JohnNiang: new pull request created: #2950 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f2c-ci-robot bot
pushed a commit
that referenced
this pull request
Dec 14, 2022
This is an automated cherry-pick of #2935 /assign JohnNiang ```release-note 支持在工作目录添加自定义配置 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/area core
/milestone 2.1.x
What this PR does / why we need it:
Force to add environment variables
HALO_WORK_DIRandSPRING_CONFIG_LOCATIONinto Dockerfile. After that, we can configureapplication.yamlin working directory as we want.Please note that we can not configure Halo working directory in
/root/.halo2/application.yamldirectly. Use environment variableHALO_WORK_DIRinstead.Which issue(s) this PR fixes:
Fixes #2812
Special notes for your reviewer:
Steps to test:
Prepare custom configuration
Start up Halo using Docker
docker run -it --rm -p12345:12345 -v `pwd`/halo2:/root/.halo2 johnniang/halo:configure-halo-in-work-dirRequest http://localhost:12345
Does this PR introduce a user-facing change?