feat: add reset config API for theme and plugin #2964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note
|
@guqing 建议在 PR 描述中也简单描述一下重置 ConfigMap 的流程。 |
|
生成 api-client 时，出现了重命名的问题：
|
重新生成一下，我改了个名 |
Done |
Okay |
ruibaby
changed the title
JohnNiang
reviewed
Dec 16, 2022
src/main/java/run/halo/app/core/extension/endpoint/PluginEndpoint.java
Outdated
Show resolved
Hide resolved
src/main/java/run/halo/app/core/extension/theme/ThemeEndpoint.java
Outdated
Show resolved
Hide resolved
f2c-ci-robot
bot
added
the
approved
JohnNiang
reviewed
Dec 16, 2022
src/main/java/run/halo/app/core/extension/endpoint/PluginEndpoint.java
Outdated
Show resolved
Hide resolved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot bot
pushed a commit
to halo-dev/console
that referenced
this pull request
Dec 19, 2022
#### What type of PR is this? /kind feature #### What this PR does / why we need it: 支持重置主题和插件的设置选项。适配 halo-dev/halo#2964 #### Which issue(s) this PR fixes: Fixes halo-dev/halo#2789 #### Screenshots: <img width="366" alt="image" src="https://user-images.githubusercontent.com/21301288/208022668-288fb8c5-ddd1-456c-9633-ec8865f3b1ba.png"> #### Special notes for your reviewer: 测试方式： 1. 安装若干带有设置选项主题和插件。 2. 进入主题和插件设置，改变部分设置并保存。 3. 重置主题和插件的设置，然后进入设置表单，检查是否已经恢复为了默认。 #### Does this PR introduce a user-facing change? ```release-note 支持重置主题和插件的设置选项。 ```
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
…ev/console#777) #### What type of PR is this? /kind feature #### What this PR does / why we need it: 支持重置主题和插件的设置选项。适配 halo-dev#2964 #### Which issue(s) this PR fixes: Fixes halo-dev#2789 #### Screenshots: <img width="366" alt="image" src="https://user-images.githubusercontent.com/21301288/208022668-288fb8c5-ddd1-456c-9633-ec8865f3b1ba.png"> #### Special notes for your reviewer: 测试方式： 1. 安装若干带有设置选项主题和插件。 2. 进入主题和插件设置，改变部分设置并保存。 3. 重置主题和插件的设置，然后进入设置表单，检查是否已经恢复为了默认。 #### Does this PR introduce a user-facing change? ```release-note 支持重置主题和插件的设置选项。 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind api-change
/area core
What this PR does / why we need it:
为主题和插件提供重置设置项 API
此 PR 会重新读取配置对应的 Setting 资源，从其中读取默认值后更新到现有的 ConfigMap 中替换其 data
see #2789 for more details
Which issue(s) this PR fixes:
Fixes #2789
Special notes for your reviewer:
how to test it?
/cc @halo-dev/sig-halo
Does this PR introduce a user-facing change?