Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: page stats does not subscribe in finder #3003

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

guqing
Copy link
Member

@guqing guqing commented Dec 19, 2022

What type of PR is this?

/kind bug
/area core

What this PR does / why we need it:

修复自定义页面 Finder 中 getByName 方法没有返回访问量的问题
此问题为重构 #2918 时引入。

Which issue(s) this PR fixes:

Fixes #2992

Special notes for your reviewer:

/cc @halo-dev/sig-halo

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. area/core Issues or PRs related to the Halo Core labels Dec 19, 2022
@JohnNiang JohnNiang added this to the 2.1.x milestone Dec 20, 2022
@JohnNiang
Copy link
Member

/cherry-pick release-2.0

@halo-dev-bot
Copy link
Collaborator

@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.0 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

/approve

image

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2022
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 9d6bcdf into halo-dev:main Dec 20, 2022
@halo-dev-bot
Copy link
Collaborator

@JohnNiang: #3003 failed to apply on top of branch "release-2.0":

Applying: fix: page stats does not subscribe in finder
Using index info to reconstruct a base tree...
M	src/main/java/run/halo/app/theme/finders/impl/SinglePageFinderImpl.java
Falling back to patching base and 3-way merge...
Auto-merging src/main/java/run/halo/app/theme/finders/impl/SinglePageFinderImpl.java
CONFLICT (content): Merge conflict in src/main/java/run/halo/app/theme/finders/impl/SinglePageFinderImpl.java
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: page stats does not subscribe in finder
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JohnNiang
Copy link
Member

由于该问题在 Halo 2.0.x 中没有问题,我们不再 cherry pick 到 release-2.0 分支中。

@JohnNiang JohnNiang modified the milestones: 2.1.x, 2.1.0 Dec 21, 2022
@guqing guqing deleted the bugfix/2992 branch December 21, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在没有安装任何插件的情况下,无法访问about页面
4 participants