Fix the problem that publishing post always fails #3210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note
|
Hi @minliacom, 有时间可以帮忙测试一下这个 PR 看发布文章失败的情况还会出现吗，我记得你之前经常遇到 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Closed
Closed
f2c-ci-robot bot
pushed a commit
that referenced
this pull request
Feb 7, 2023
#### What type of PR is this? /kind improvement /area core /milestone 2.3.x #### What this PR does / why we need it: 当开发模式启动时上传 JAR 运行插件会出现插件不存在的异常，但由于 PluginReconciler 中检查状态不一致后 return 在 optional 语句中只是让当前 optional 后面的代码停止执行，还会继续执行 optional 外面的代码导致 status 的异常信息不一致，进而 object equals 始终为 false 而无法让 reconciler 终止运行导致循环。 此 PR 调整了一下代码位置，进入 reconciler 时先进行检查，如果不满足则不执行后面的代码同时将信息写入 plugin.status 让用户知晓。 此问题是修改了 Reconciler 判断逻辑后出现的 #3210 ，因此不影响之前的代码只针对当前 2.3.x #### Special notes for your reviewer: how to test it? 1. 模拟一个插件找不到的错误场景例如以生产模式启动插件但配置 fixed-plugin 指定为插件项目目录 2. 启动 Halo 看 Reconciler 是否会一直在控制台输出日志 3. 卸载它能成功 /cc @halo-dev/sig-halo #### Does this PR introduce a user-facing change? ```release-note None ```
|
/cherry-pick release-2.2 |
|
@ruibaby: new pull request created: #3276 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f2c-ci-robot bot
pushed a commit
that referenced
this pull request
Feb 10, 2023
This is an automated cherry-pick of #3210 /assign ruibaby ```release-note 修复发布文章时经常出现错误的问题 ```
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/area core
/milestone 2.3.x
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2860
Special notes for your reviewer:
Please take some time to test publishing posts.
Does this PR introduce a user-facing change?