Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add email hash into annotation of spec of comment for anonymous #5642

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

ShiinaKin
Copy link
Contributor

@ShiinaKin ShiinaKin commented Apr 3, 2024

/kind feature
/area core

What this PR does / why we need it:

see halo-dev/plugin-comment-widget#97

Which issue(s) this PR fixes:

Fixes #5641

评论数据返回邮箱地址 hash 值以便生成默认头像

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/core Issues or PRs related to the Halo Core labels Apr 3, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and LIlGG April 3, 2024 19:55
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢 @mashirot 参与贡献~

我这里有一些改进建议。

@ShiinaKin ShiinaKin requested a review from ruibaby April 4, 2024 09:10
Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 56.49%. Comparing base (5fdf6c0) to head (f3202cf).
Report is 95 commits behind head on main.

Files Patch % Lines
...me/finders/impl/CommentPublicQueryServiceImpl.java 85.71% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5642      +/-   ##
============================================
- Coverage     56.91%   56.49%   -0.42%     
- Complexity     3319     3320       +1     
============================================
  Files           587      595       +8     
  Lines         18968    19264     +296     
  Branches       1401     1361      -40     
============================================
+ Hits          10795    10884      +89     
- Misses         7594     7814     +220     
+ Partials        579      566      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShiinaKin ShiinaKin requested a review from JohnNiang April 8, 2024 07:04
Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thank you for your contribution!

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit c630a37 into halo-dev:main Apr 8, 2024
8 checks passed
@ruibaby ruibaby changed the title feat: add gravatar url into annotation of spec of comment for anonymous feat: add email hash into annotation of spec of comment for anonymous Apr 8, 2024
@ShiinaKin ShiinaKin deleted the issue-5641 branch April 8, 2024 12:47
f2c-ci-robot bot pushed a commit to halo-dev/plugin-comment-widget that referenced this pull request Apr 9, 2024
后端改动:halo-dev/halo#5642


Fixes #97
Fixes #77

两个不同邮箱,相同头像

效果:
![image](https://github.com/halo-dev/plugin-comment-widget/assets/52254895/3b61eaec-4cca-4425-8735-827d3f06ba72)

```release-note
评论头像支持使用 Gravatar 源
```
@ruibaby ruibaby modified the milestone: 2.15.x Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

向comment annotation添加gravatar头像链接 验证使用Gravatar的可行性
4 participants