-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add email hash into annotation of spec of comment for anonymous #5642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感谢 @mashirot 参与贡献~
我这里有一些改进建议。
application/src/main/java/run/halo/app/theme/finders/impl/CommentPublicQueryServiceImpl.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5642 +/- ##
============================================
- Coverage 56.91% 56.49% -0.42%
- Complexity 3319 3320 +1
============================================
Files 587 595 +8
Lines 18968 19264 +296
Branches 1401 1361 -40
============================================
+ Hits 10795 10884 +89
- Misses 7594 7814 +220
+ Partials 579 566 -13 ☔ View full report in Codecov by Sentry. |
api/src/main/java/run/halo/app/core/extension/content/Comment.java
Outdated
Show resolved
Hide resolved
application/src/main/java/run/halo/app/theme/finders/impl/CommentPublicQueryServiceImpl.java
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thank you for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
后端改动:halo-dev/halo#5642 Fixes #97 Fixes #77 两个不同邮箱,相同头像 效果: ![image](https://github.com/halo-dev/plugin-comment-widget/assets/52254895/3b61eaec-4cca-4425-8735-827d3f06ba72) ```release-note 评论头像支持使用 Gravatar 源 ```
/kind feature
/area core
What this PR does / why we need it:
see halo-dev/plugin-comment-widget#97
Which issue(s) this PR fixes:
Fixes #5641