-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove phone field for user form #6139
refactor: remove phone field for user form #6139
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6139 +/- ##
============================================
- Coverage 56.91% 54.78% -2.13%
- Complexity 3319 3432 +113
============================================
Files 587 629 +42
Lines 18968 21185 +2217
Branches 1401 1482 +81
============================================
+ Hits 10795 11607 +812
- Misses 7594 8988 +1394
- Partials 579 590 +11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This reverts commit f09b685.
What type of PR is this?
/area ui
/kind improvement
/milestone 2.17.x
What this PR does / why we need it:
移除用户创建/编辑表单的手机号字段,当前手机号在系统中没有任何使用。
Does this PR introduce a user-facing change?