Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove phone field for user form #6139

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 25, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.17.x

What this PR does / why we need it:

移除用户创建/编辑表单的手机号字段,当前手机号在系统中没有任何使用。

Does this PR introduce a user-facing change?

None

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. area/ui Issues or PRs related to the Halo UI labels Jun 25, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jun 25, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wzrove June 25, 2024 09:05
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.78%. Comparing base (5fdf6c0) to head (ae650eb).
Report is 261 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6139      +/-   ##
============================================
- Coverage     56.91%   54.78%   -2.13%     
- Complexity     3319     3432     +113     
============================================
  Files           587      629      +42     
  Lines         18968    21185    +2217     
  Branches       1401     1482      +81     
============================================
+ Hits          10795    11607     +812     
- Misses         7594     8988    +1394     
- Partials        579      590      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
Copy link

f2c-ci-robot bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit f09b685 into halo-dev:main Jun 26, 2024
7 checks passed
@ruibaby ruibaby deleted the refactor/remove-phone-field branch June 26, 2024 03:58
@ruibaby ruibaby modified the milestones: 2.17.x, 2.17.0 Jun 26, 2024
ruibaby added a commit to ruibaby/halo that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants