chore: cleanup deprecated constructor for base plugin

api/src/main/java/run/halo/app/plugin/BasePlugin.java

@@ -2,9 +2,7 @@
 
 import lombok.extern.slf4j.Slf4j;
 import org.pf4j.Plugin;
-import org.pf4j.PluginWrapper;
 import org.springframework.lang.NonNull;
-import org.springframework.util.Assert;
 
 /**
  * This class will be extended by all plugins and serve as the common class between a plugin and
@@ -16,44 +14,17 @@
 @Slf4j
 public class BasePlugin extends Plugin {
 
-    protected PluginContext context;
-
-    @Deprecated
-    public BasePlugin(PluginWrapper wrapper) {
-        super(wrapper);
-        log.info("Initialized plugin {}", wrapper.getPluginId());
-    }
+    protected final PluginContext context;
 
     /**
      * Constructor a plugin with the given plugin context.
-     * TODO Mark {@link PluginContext} as final to prevent modification.
      *
      * @param pluginContext plugin context must not be null.
      */
     public BasePlugin(PluginContext pluginContext) {
         this.context = pluginContext;
     }
 
-    /**
-     * use {@link #BasePlugin(PluginContext)} instead of.
-     *
-     * @deprecated since 2.10.0
-     */
-    public BasePlugin() {
-    }
-
-    /**
-     * Compatible with old constructors, if the plugin is not use
-     * {@link #BasePlugin(PluginContext)} constructor then base plugin factory will use this
-     * method to set plugin context.
-     *
-     * @param context plugin context must not be null.
-     */
-    final void setContext(PluginContext context) {
-        Assert.notNull(context, "Plugin context must not be null");
-        this.context = context;
-    }
-
     @NonNull
     public PluginContext getContext() {
         return context;

application/src/main/java/run/halo/app/plugin/DefaultPluginApplicationContextFactory.java

@@ -85,7 +85,6 @@ public ApplicationContext create(String pluginId) {
         sw.start("RegisterBeans");
         var beanFactory = context.getBeanFactory();
         context.registerBean(AggregatedRouterFunction.class);
-        beanFactory.registerSingleton("pluginWrapper", pluginWrapper);
 
         if (pluginWrapper.getPlugin() instanceof SpringPlugin springPlugin) {
             beanFactory.registerSingleton("pluginContext", springPlugin.getPluginContext());

application/src/main/java/run/halo/app/plugin/HaloPluginManager.java

@@ -15,7 +15,6 @@
 import org.pf4j.ExtensionFinder;
 import org.pf4j.JarPluginLoader;
 import org.pf4j.JarPluginRepository;
-import org.pf4j.PluginDescriptor;
 import org.pf4j.PluginDescriptorFinder;
 import org.pf4j.PluginFactory;
 import org.pf4j.PluginLoader;
@@ -95,17 +94,6 @@ protected PluginDescriptorFinder createPluginDescriptorFinder() {
         return new YamlPluginDescriptorFinder();
     }
 
-    @Override
-    protected PluginWrapper createPluginWrapper(PluginDescriptor pluginDescriptor, Path pluginPath,
-        ClassLoader pluginClassLoader) {
-        // create the plugin wrapper
-        log.debug("Creating wrapper for plugin '{}'", pluginPath);
-        var pluginWrapper =
-            new HaloPluginWrapper(this, pluginDescriptor, pluginPath, pluginClassLoader);
-        pluginWrapper.setPluginFactory(getPluginFactory());
-        return pluginWrapper;
-    }
-
     @Override
     protected PluginLoader createPluginLoader() {
         var compoundLoader = new CompoundPluginLoader();

application/src/main/java/run/halo/app/plugin/SpringPlugin.java

@@ -40,9 +40,6 @@ public void start() {
             log.info("After publishing plugin starting event for plugin {}", pluginId);
             if (pluginOpt.isPresent()) {
                 this.delegate = pluginOpt.get();
-                if (this.delegate instanceof BasePlugin basePlugin) {
-                    basePlugin.setContext(pluginContext);
-                }
                 log.info("Starting {} for plugin {}", this.delegate, pluginId);
                 this.delegate.start();
                 log.info("Started {} for plugin {}", this.delegate, pluginId);