Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for video thumbnail preview in the attachment library #6265

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

LonelySnowman
Copy link
Contributor

@LonelySnowman LonelySnowman commented Jul 3, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

附件页面视频文件展示封面

Which issue(s) this PR fixes:

Fixes #5945

Special notes for your reviewer:

image

Does this PR introduce a user-facing change?

附件库支持预览视频封面。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 3, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.25%. Comparing base (bc10336) to head (2ecd26f).
Report is 72 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6265      +/-   ##
============================================
+ Coverage     54.51%   58.25%   +3.74%     
- Complexity     3523     3759     +236     
============================================
  Files           646      646              
  Lines         21862    21964     +102     
  Branches       1528     1541      +13     
============================================
+ Hits          11917    12796     +879     
+ Misses         9328     8547     -781     
- Partials        617      621       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LonelySnowman
Copy link
Contributor Author

可以重新跑下 e2e-test 嘛,我看了下我这边的改动应该不会影响到 http://halo:8090/apis/api.console.halo.run/v1alpha1/users/vuVGTj/password 报错的这个接口。

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢参与贡献,以下是一些改进建议。

@ruibaby ruibaby changed the title feat: video attachments add cover feat: add support for video thumbnail preview in the attachment library Jul 9, 2024
@ruibaby ruibaby added this to the 2.18.x milestone Jul 9, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2024
Copy link

f2c-ci-robot bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 66d4986 into halo-dev:main Jul 10, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.18.x, 2.18.0 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

建议halo附件库添加显示视频封面
3 participants