-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for video thumbnail preview in the attachment library #6265
feat: add support for video thumbnail preview in the attachment library #6265
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6265 +/- ##
============================================
+ Coverage 54.51% 58.25% +3.74%
- Complexity 3523 3759 +236
============================================
Files 646 646
Lines 21862 21964 +102
Branches 1528 1541 +13
============================================
+ Hits 11917 12796 +879
+ Misses 9328 8547 -781
- Partials 617 621 +4 ☔ View full report in Codecov by Sentry. |
可以重新跑下 e2e-test 嘛,我看了下我这边的改动应该不会影响到 http://halo:8090/apis/api.console.halo.run/v1alpha1/users/vuVGTj/password 报错的这个接口。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感谢参与贡献,以下是一些改进建议。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
附件页面视频文件展示封面
Which issue(s) this PR fixes:
Fixes #5945
Special notes for your reviewer:
Does this PR introduce a user-facing change?