-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: mark deprecated constructor for base plugin #6277
Conversation
/cherry-pick release-2.17 |
@guqing: once the present PR merges, I will cherry-pick it on top of release-2.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6277 +/- ##
============================================
+ Coverage 54.51% 58.28% +3.77%
- Complexity 3523 3763 +240
============================================
Files 646 647 +1
Lines 21862 21965 +103
Branches 1528 1541 +13
============================================
+ Hits 11917 12802 +885
+ Misses 9328 8545 -783
- Partials 617 618 +1 ☔ View full report in Codecov by Sentry. |
e12dbfb
to
2ac5013
Compare
2ac5013
to
10f2539
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@guqing: #6277 failed to apply on top of branch "release-2.17":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/milestone 2.18.x
What this PR does / why we need it:
将 BasePlugin 的 PluginWrapper 构造函数标记为过时并输出警告日志提示
Does this PR introduce a user-facing change?