Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mark deprecated constructor for base plugin #6277

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Jul 5, 2024

What type of PR is this?

/milestone 2.18.x

What this PR does / why we need it:

将 BasePlugin 的 PluginWrapper 构造函数标记为过时并输出警告日志提示

Does this PR introduce a user-facing change?

在 BasePlugin 的 PluginWrapper 构造函数输出过时警告日志以提醒开发者尽快适配

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 5, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.18.x milestone Jul 5, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wan92hen July 5, 2024 08:55
@guqing
Copy link
Member Author

guqing commented Jul 5, 2024

/cherry-pick release-2.17

@halo-dev-bot
Copy link
Collaborator

@guqing: once the present PR merges, I will cherry-pick it on top of release-2.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 58.28%. Comparing base (bc10336) to head (60bb3c0).
Report is 67 commits behind head on main.

Files Patch % Lines
.../src/main/java/run/halo/app/plugin/BasePlugin.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6277      +/-   ##
============================================
+ Coverage     54.51%   58.28%   +3.77%     
- Complexity     3523     3763     +240     
============================================
  Files           646      647       +1     
  Lines         21862    21965     +103     
  Branches       1528     1541      +13     
============================================
+ Hits          11917    12802     +885     
+ Misses         9328     8545     -783     
- Partials        617      618       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 5, 2024
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2024
Copy link

f2c-ci-robot bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 104bd3e into halo-dev:main Jul 5, 2024
7 checks passed
@halo-dev-bot
Copy link
Collaborator

@guqing: #6277 failed to apply on top of branch "release-2.17":

Applying: chore: mark deprecated constructor for base plugin
Using index info to reconstruct a base tree...
M	api/src/main/java/run/halo/app/plugin/BasePlugin.java
Falling back to patching base and 3-way merge...
Auto-merging api/src/main/java/run/halo/app/plugin/BasePlugin.java
CONFLICT (content): Merge conflict in api/src/main/java/run/halo/app/plugin/BasePlugin.java
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 chore: mark deprecated constructor for base plugin
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-2.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guqing guqing deleted the chore/base-plugin-log branch July 5, 2024 10:06
@ruibaby ruibaby modified the milestones: 2.18.x, 2.18.0 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants