-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the problem that plugins without jar file may not be deleted #6334
Fix the problem that plugins without jar file may not be deleted #6334
Conversation
…eted Signed-off-by: JohnNiang <johnniang@foxmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6334 +/- ##
============================================
+ Coverage 54.51% 58.27% +3.76%
- Complexity 3523 3763 +240
============================================
Files 646 646
Lines 21862 21979 +117
Branches 1528 1545 +17
============================================
+ Hits 11917 12809 +892
+ Misses 9328 8550 -778
- Partials 617 620 +3 ☔ View full report in Codecov by Sentry. |
/cherrypick release-2.17 |
@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JohnNiang: #6334 failed to apply on top of branch "release-2.17":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…o-dev#6334) /kind bug /area core /area plugin /milestone 2.18.x This PR checks if the plugin is already unloaded while getting dependents to fix the problem that plugins without jar file may not be deleted or not be enabled or disabled. Fixes halo-dev#6072 1. Try to move plugins folder to another folder 2. Restart Halo 3. Try to change state of plugins or delete plugins directly 4. See the result ```release-note 修复在没有插件文件的情况下可能无法删除插件的问题 ```
What type of PR is this?
/kind bug
/area core
/area plugin
/milestone 2.18.x
What this PR does / why we need it:
This PR checks if the plugin is already unloaded while getting dependents to fix the problem that plugins without jar file may not be deleted or not be enabled or disabled.
Which issue(s) this PR fixes:
Fixes #6072
Special notes for your reviewer:
Does this PR introduce a user-facing change?