-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enter key causing focus loss in default editor title during composition input #6347
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6347 +/- ##
============================================
+ Coverage 54.51% 58.29% +3.78%
- Complexity 3523 3764 +241
============================================
Files 646 646
Lines 21862 21978 +116
Branches 1528 1545 +17
============================================
+ Hits 11917 12813 +896
+ Misses 9328 8546 -782
- Partials 617 619 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/area editor
/milestone 2.18.x
What this PR does / why we need it:
使用组合输入时,按下回车键不再执行编辑器获取焦点的事件。
Which issue(s) this PR fixes:
Fixes #6345
Does this PR introduce a user-facing change?