Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enter key causing focus loss in default editor title during composition input #6347

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Jul 18, 2024

What type of PR is this?

/kind bug
/area editor
/milestone 2.18.x

What this PR does / why we need it:

使用组合输入时,按下回车键不再执行编辑器获取焦点的事件。

Which issue(s) this PR fixes:

Fixes #6345

Does this PR introduce a user-facing change?

解决默认编辑器标题在使用组合输入时,按下回车键会导致其失去焦点的问题。

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 18, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.18.x milestone Jul 18, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label Jul 18, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang July 18, 2024 07:43
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.29%. Comparing base (bc10336) to head (48245e4).
Report is 80 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6347      +/-   ##
============================================
+ Coverage     54.51%   58.29%   +3.78%     
- Complexity     3523     3764     +241     
============================================
  Files           646      646              
  Lines         21862    21978     +116     
  Branches       1528     1545      +17     
============================================
+ Hits          11917    12813     +896     
+ Misses         9328     8546     -782     
- Partials        617      619       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 6791b5e into halo-dev:main Jul 22, 2024
7 checks passed
@LIlGG LIlGG deleted the fix/title-composing-enter branch July 22, 2024 06:47
@ruibaby ruibaby modified the milestones: 2.18.x, 2.18.0 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

默认编辑器标题在组合输入时回车会中断输入
3 participants