Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extension point for excerpt generation #6348

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Jul 18, 2024

What type of PR is this?

/kind feature
/area core
/milestone 2.18.x

What this PR does / why we need it:

新增文章摘要生成扩展点用于扩展自动生成摘要的方式

Does this PR introduce a user-facing change?

新增文章摘要生成扩展点用于扩展自动生成摘要的方式

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 18, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.18.x milestone Jul 18, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jul 18, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and ruibaby July 18, 2024 08:18
@guqing guqing added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 18, 2024
@guqing guqing force-pushed the feature/excerpt-ext-point branch from 351dccc to 0b95589 Compare July 18, 2024 08:30
@guqing guqing force-pushed the feature/excerpt-ext-point branch from 0b95589 to d25fcce Compare July 18, 2024 09:52
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 16 lines in your changes missing coverage. Please review.

Project coverage is 58.36%. Comparing base (bc10336) to head (2dbf65b).
Report is 97 commits behind head on main.

Files Patch % Lines
...in/java/run/halo/app/content/ExcerptGenerator.java 0.00% 6 Missing ⚠️
.../app/core/extension/reconciler/PostReconciler.java 87.17% 5 Missing ⚠️
...ore/extension/reconciler/SinglePageReconciler.java 81.48% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6348      +/-   ##
============================================
+ Coverage     54.51%   58.36%   +3.85%     
- Complexity     3523     3770     +247     
============================================
  Files           646      647       +1     
  Lines         21862    22038     +176     
  Branches       1528     1548      +20     
============================================
+ Hits          11917    12862     +945     
+ Misses         9328     8554     -774     
- Partials        617      622       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guqing guqing force-pushed the feature/excerpt-ext-point branch from b5908fa to 63e5ff9 Compare July 25, 2024 10:04
Copy link

sonarcloud bot commented Jul 30, 2024

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

需要在 https://github.com/halo-dev/docs 补充文档。

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ping @LIlGG

Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Jul 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, LIlGG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 39ff455 into halo-dev:main Jul 31, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.18.x, 2.18.0 Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/docs Categorizes an issue or PR as relevant to SIG Docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants