Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.17] Respond 404 for non-exist theme resources instead of 500 #6355

Conversation

halo-dev-bot
Copy link
Collaborator

This is an automated cherry-pick of #6340

/assign JohnNiang

修复访问不存在的主题资源时出现服务器异常的问题

Signed-off-by: JohnNiang <johnniang@foxmail.com>
@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 22, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby July 22, 2024 04:36
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release-2.17@6d4bedd). Learn more about missing BASE report.

Files Patch % Lines
.../halo/app/theme/config/ThemeWebFluxConfigurer.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-2.17    #6355   +/-   ##
===============================================
  Coverage                ?   58.06%           
  Complexity              ?     3757           
===============================================
  Files                   ?      649           
  Lines                   ?    22033           
  Branches                ?     1551           
===============================================
  Hits                    ?    12794           
  Misses                  ?     8616           
  Partials                ?      623           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2024
Copy link

f2c-ci-robot bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 19e45e0 into halo-dev:release-2.17 Jul 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants