Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add retry mechanism for publishing posts in user center #6406

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jul 29, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.18.x

What this PR does / why we need it:

为个人中心发布文章的操作添加重试机制,方式后端因为乐观锁出现异常错误。

Which issue(s) this PR fixes:

Fixes #6349

Does this PR introduce a user-facing change?

为个人中心发布文章的操作添加重试机制,防止后端因为乐观锁出现异常错误。

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 29, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.18.x milestone Jul 29, 2024
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. labels Jul 29, 2024
Copy link

sonarcloud bot commented Jul 29, 2024

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.32%. Comparing base (bc10336) to head (20f1ca6).
Report is 89 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6406      +/-   ##
============================================
+ Coverage     54.51%   58.32%   +3.81%     
- Complexity     3523     3766     +243     
============================================
  Files           646      646              
  Lines         21862    21989     +127     
  Branches       1528     1546      +18     
============================================
+ Hits          11917    12826     +909     
+ Misses         9328     8540     -788     
- Partials        617      623       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2024
Copy link

f2c-ci-robot bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit f7ee732 into halo-dev:main Jul 29, 2024
8 checks passed
@ruibaby ruibaby deleted the fix/add-retry-feature-for-publish-post branch July 29, 2024 10:15
@ruibaby ruibaby modified the milestones: 2.18.x, 2.18.0 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

修改文章,再次发布经常出现发布失败、服务器内部发生错误
2 participants