Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backspace on empty line doesn’t return to previous list item #6445

Merged

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Aug 7, 2024

What type of PR is this?

/kind bug
/area editor
/milestone 2.19.x

What this PR does / why we need it:

修复默认编辑器中,当在列表的下一空白行使用退格键时,会导致无法回退至列表项中的问题。

How to test it?

  1. 在编辑器中增加一个列表项。
  2. 按两次回车跳出列表编辑器。
  3. 按退格键。

查看退格键是否按一次就可以回到列表项,并且再次按时执行列表项的删除。

Which issue(s) this PR fixes:

Fixes #6263

Does this PR introduce a user-facing change?

解决默认编辑器中在空白行中按退格键无法回退到列表项中的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Aug 7, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.19.x milestone Aug 7, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label Aug 7, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang August 7, 2024 08:17
Copy link

sonarqubecloud bot commented Aug 7, 2024

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.15%. Comparing base (bc10336) to head (5d8d91b).
Report is 107 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6445      +/-   ##
============================================
+ Coverage     54.51%   58.15%   +3.64%     
- Complexity     3523     3769     +246     
============================================
  Files           646      651       +5     
  Lines         21862    22106     +244     
  Branches       1528     1555      +27     
============================================
+ Hits          11917    12855     +938     
+ Misses         9328     8628     -700     
- Partials        617      623       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 94f28cc into halo-dev:main Aug 8, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.19.x, 2.19.0 Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot back to upper list line after pressing backspace in blank line
3 participants