-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct device information update during account switch #6483
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6483 +/- ##
============================================
+ Coverage 54.51% 58.22% +3.71%
- Complexity 3523 3778 +255
============================================
Files 646 651 +5
Lines 21862 22138 +276
Branches 1528 1555 +27
============================================
+ Hits 11917 12890 +973
+ Misses 9328 8625 -703
- Partials 617 623 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我还发现另外一个问题:在同一个浏览器中频繁切换账号会导致设备使用记录越来越多。
这是正常的,切换了账号之后设备id就不在了,目前检测设备是靠设备 id 的 cookie 的,设备记录超过10个会被清理 |
我仍然坚持我的观点:这种现象是不正常的。这种场景应该和登录后登出再登录的结果保持一致。不过这并不妨碍当前 PR 的合并。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/area core
/milestone 2.19.x
What this PR does / why we need it:
修复切换账号登录时设备信息更新不正确的问题
原因:
how to test it?
Does this PR introduce a user-facing change?