Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add filter options for attachment selector component #6505

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Aug 23, 2024

What type of PR is this?

/area ui
/kind feature
/milestone 2.19.0

What this PR does / why we need it:

为附件选择组件添加更多筛选项支持。

image

Which issue(s) this PR fixes:

Fixes #4605
Fixes #6352

Special notes for your reviewer:

需要测试附件选择组件的各项功能是否符合预期。

Does this PR introduce a user-facing change?

为附件选择组件添加更多筛选项支持。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Aug 23, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.19.0 milestone Aug 23, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 23, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wzrove August 23, 2024 08:32
Copy link

@ruibaby ruibaby requested review from LIlGG and guqing August 23, 2024 08:35
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.19%. Comparing base (6cd8dc8) to head (4c35150).
Report is 9 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6505      +/-   ##
============================================
+ Coverage     58.18%   58.19%   +0.01%     
+ Complexity     3774     3773       -1     
============================================
  Files           651      651              
  Lines         22125    22128       +3     
  Branches       1538     1538              
============================================
+ Hits          12873    12877       +4     
  Misses         8641     8641              
+ Partials        611      610       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Aug 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit c92bbd7 into halo-dev:main Aug 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
3 participants