Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: preserve original image if smaller than requested thumbnail size #6582

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Sep 4, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.20.x

What this PR does / why we need it:

当生成缩略图时如果原图尺寸小于请求尺寸则返回原图以保持其质量

Which issue(s) this PR fixes:

Fixes #6579

Does this PR introduce a user-facing change?

当生成缩略图时如果原图尺寸小于请求尺寸则返回原图以保持其质量

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Sep 4, 2024
Copy link

f2c-ci-robot bot commented Sep 4, 2024

@guqing: The provided milestone is not valid for this repository. Milestones in this repository: [2.17.x, 2.18.x, 2.19.1, 2.19.x, 2.20.x, Backlog]

Use /milestone clear to clear the milestone.

In response to this:

What type of PR is this?

/kind improvement
/area core
/milestone 2.10.x

What this PR does / why we need it:

当生成缩略图时如果原图尺寸小于请求尺寸则返回原图以保持其质量

Which issue(s) this PR fixes:

Fixes #6579

Does this PR introduce a user-facing change?

当生成缩略图时如果原图尺寸小于请求尺寸则返回原图以保持其质量

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Sep 4, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen September 4, 2024 03:47
@guqing guqing added this to the 2.20.x milestone Sep 4, 2024
Copy link

sonarqubecloud bot commented Sep 4, 2024

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 58.04%. Comparing base (6cd8dc8) to head (4d43720).
Report is 50 commits behind head on main.

Files with missing lines Patch % Lines
...n/halo/app/core/attachment/ThumbnailGenerator.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6582      +/-   ##
============================================
- Coverage     58.18%   58.04%   -0.14%     
- Complexity     3774     3916     +142     
============================================
  Files           651      670      +19     
  Lines         22125    22963     +838     
  Branches       1538     1574      +36     
============================================
+ Hits          12873    13330     +457     
- Misses         8641     9017     +376     
- Partials        611      616       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruibaby
Copy link
Member

ruibaby commented Sep 4, 2024

/cherry-pick release-2.19

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 7991ef8 into halo-dev:main Sep 4, 2024
8 checks passed
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #6583

In response to this:

/cherry-pick release-2.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guqing guqing deleted the refactor/6579 branch September 4, 2024 06:13
f2c-ci-robot bot pushed a commit that referenced this pull request Sep 4, 2024
…ested thumbnail size (#6583)

This is an automated cherry-pick of #6582

/assign ruibaby

```release-note
当生成缩略图时如果原图尺寸小于请求尺寸则返回原图以保持其质量
```
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.19版本图片响应式对小尺寸图片显示不友好
4 participants