-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve issue with disabled property in options not working #6595
Conversation
Quality Gate passedIssues Measures |
/cherrypick release-2.19 |
@LIlGG: once the present PR merges, I will cherry-pick it on top of release-2.19 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@liuchangfitcloud: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6595 +/- ##
============================================
- Coverage 58.18% 58.04% -0.15%
- Complexity 3774 3915 +141
============================================
Files 651 670 +19
Lines 22125 22963 +838
Branches 1538 1574 +36
============================================
+ Hits 12873 13328 +455
- Misses 8641 9018 +377
- Partials 611 617 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@LIlGG: new pull request created: #6608 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
/area ui
What this PR does / why we need it:
解决 formkit select 组件中,option 使用
attrs: { disabled: true }
无效的问题。How to test it?
测试在 formkit select 组件中,option 设置 disabled 属性是否有效。
Which issue(s) this PR fixes:
Fixed #6592
Does this PR introduce a user-facing change?