pref: improve hover and pre-selection state for formkit select #6607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
kind/improvement
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6607 +/- ##
============================================
- Coverage 58.18% 58.06% -0.13%
- Complexity 3774 3917 +143
============================================
Files 651 670 +19
Lines 22125 22963 +838
Branches 1538 1574 +36
============================================
+ Hits 12873 13333 +460
- Misses 8641 9013 +372
- Partials 611 617 +6 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/area ui
/milestone 2.20.x
What this PR does / why we need it:
优化了 Formkit 中的 selec 组件，使得其使用快捷键与鼠标选中的预选状态始终只有一个。且在多选状态下按回车时，不再预选跳转至第一个选项。
How to test it?
在多选状态下测试使用键盘进行预选及使用鼠标 hover 进行预选的状态是否符合预期。
Which issue(s) this PR fixes:
Fixes #6600
Does this PR introduce a user-facing change?