Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: prevent replies to comments that are pending approval #6622

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Sep 9, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.20.x

What this PR does / why we need it:

不允许回复未通过审核的评论

Does this PR introduce a user-facing change?

禁止非管理员回复未通过审核的评论

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 9, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Sep 9, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Sep 9, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and LIlGG September 9, 2024 06:54
Copy link

sonarqubecloud bot commented Sep 9, 2024

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 3.44828% with 28 lines in your changes missing coverage. Please review.

Project coverage is 58.07%. Comparing base (6cd8dc8) to head (0cf2029).
Report is 66 commits behind head on main.

Files with missing lines Patch % Lines
...run/halo/app/content/comment/ReplyServiceImpl.java 4.00% 24 Missing ⚠️
...pp/infra/exception/RequestRestrictedException.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6622      +/-   ##
============================================
- Coverage     58.18%   58.07%   -0.11%     
- Complexity     3774     3919     +145     
============================================
  Files           651      671      +20     
  Lines         22125    22981     +856     
  Branches       1538     1575      +37     
============================================
+ Hits          12873    13346     +473     
- Misses         8641     9019     +378     
- Partials        611      616       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 7ed859c into halo-dev:main Sep 13, 2024
8 checks passed
@guqing guqing deleted the refactor/reply branch September 13, 2024 02:36
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants