-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update attachment permalink only when handler is available #6641
Update attachment permalink only when handler is available #6641
Conversation
Signed-off-by: JohnNiang <johnniang@foxmail.com>
674eb45
to
36c7cd5
Compare
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6641 +/- ##
============================================
- Coverage 58.18% 58.07% -0.11%
- Complexity 3774 3917 +143
============================================
Files 651 670 +19
Lines 22125 22971 +846
Branches 1538 1576 +38
============================================
+ Hits 12873 13340 +467
- Misses 8641 9014 +373
- Partials 611 617 +6 ☔ View full report in Codecov by Sentry. |
The failing check can be ingored because SonarCloud analyzed old code. I tried to rerun the check, but nothing happened. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm going to merge this PR manually due to invalid check of SonarCloud Code Analysis. |
What type of PR is this?
/kind improvement
/area core
/area plugin
What this PR does / why we need it:
This PR removes deprecated code that was for backward compatibility and lets reconciler requeue if attachment handler is unavailable.
Which issue(s) this PR fixes:
Fixes #4439
Does this PR introduce a user-facing change?