Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attachment permalink only when handler is available #6641

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind improvement
/area core
/area plugin

What this PR does / why we need it:

This PR removes deprecated code that was for backward compatibility and lets reconciler requeue if attachment handler is unavailable.

Which issue(s) this PR fixes:

Fixes #4439

Does this PR introduce a user-facing change?

解决重启后可能无法更新附件链接的问题

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 11, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from guqing September 11, 2024 09:41
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Sep 11, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from LIlGG September 11, 2024 09:41
@f2c-ci-robot f2c-ci-robot bot added the area/plugin Issues or PRs related to the Plugin Provider label Sep 11, 2024
Signed-off-by: JohnNiang <johnniang@foxmail.com>
@JohnNiang JohnNiang force-pushed the bug/cannot-update-permalink-after-restarting branch from 674eb45 to 36c7cd5 Compare September 11, 2024 09:54
Copy link

sonarqubecloud bot commented Sep 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 58.07%. Comparing base (6cd8dc8) to head (36c7cd5).
Report is 62 commits behind head on main.

Files with missing lines Patch % Lines
...re/attachment/reconciler/AttachmentReconciler.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6641      +/-   ##
============================================
- Coverage     58.18%   58.07%   -0.11%     
- Complexity     3774     3917     +143     
============================================
  Files           651      670      +19     
  Lines         22125    22971     +846     
  Branches       1538     1576      +38     
============================================
+ Hits          12873    13340     +467     
- Misses         8641     9014     +373     
- Partials        611      617       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnNiang
Copy link
Member Author

JohnNiang commented Sep 11, 2024

The failing check can be ingored because SonarCloud analyzed old code. I tried to rerun the check, but nothing happened.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2024
Copy link

f2c-ci-robot bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2024
@JohnNiang
Copy link
Member Author

I'm going to merge this PR manually due to invalid check of SonarCloud Code Analysis.

@JohnNiang JohnNiang merged commit ba18f70 into halo-dev:main Sep 12, 2024
6 of 8 checks passed
@JohnNiang JohnNiang deleted the bug/cannot-update-permalink-after-restarting branch September 12, 2024 03:02
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core area/plugin Issues or PRs related to the Plugin Provider kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

启动程序时 AttachmentReconciler 不能更新使用插件上传的附件的 Permalink
3 participants