Fix the problem of resolving locale context by language parameter #6647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JohnNiang <johnniang@foxmail.com>
f2c-ci-robot
bot
added
release-note
f2c-ci-robot
bot
added
the
area/theme
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6647 +/- ##
============================================
- Coverage 58.18% 58.08% -0.10%
- Complexity 3774 3919 +145
============================================
Files 651 670 +19
Lines 22125 22977 +852
Branches 1538 1576 +38
============================================
+ Hits 12873 13346 +473
- Misses 8641 9014 +373
- Partials 611 617 +6 ☔ View full report in Codecov by Sentry. |
f2c-ci-robot bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
#### What type of PR is this? /kind improvement /area theme /milestone 2.20.x #### What this PR does / why we need it: This PR simplifies ThemeLocaleContextResolver by removing unused attributes. In another PR <#6647>, fixed locale resolution for query parameter `language`. This PR fixes locale resolution for cookie `language` as well. Please see the results below: ```bash http https://www.halo.run/ Cookie:language=zh-CN -p h HTTP/1.1 200 OK Content-Language: und ``` ```bash http http://localhost:8090 Cookie:language=zh-CN -p h HTTP/1.1 200 OK Content-Language: zh-CN ``` #### Does this PR introduce a user-facing change? ```release-note None ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/area theme
/milestone 2.20.x
What this PR does / why we need it:
If we pass a query
languagewhile requesting index page, we will get the wrong headerContent-Language. Please see the result below:After fixing, we will get the right header
Content-Language.Does this PR introduce a user-facing change?