Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct ordered list styling issue in editor #6656

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 13, 2024

What type of PR is this?

/area ui
/kind bug
/milestone 2.20.x

What this PR does / why we need it:

修复编辑器中有序列表的样式问题。

Which issue(s) this PR fixes:

Fixes #6615

Does this PR introduce a user-facing change?

修复编辑器中有序列表的样式问题。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 13, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Sep 13, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 13, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wzrove September 13, 2024 08:47
Copy link

pkg-pr-new bot commented Sep 13, 2024

Open in Stackblitz

@halo-dev/api-client

pnpm add https://pkg.pr.new/@halo-dev/api-client@6656

@halo-dev/components

pnpm add https://pkg.pr.new/@halo-dev/components@6656

@halo-dev/richtext-editor

pnpm add https://pkg.pr.new/@halo-dev/richtext-editor@6656

@halo-dev/console-shared

pnpm add https://pkg.pr.new/@halo-dev/console-shared@6656

@halo-dev/ui-plugin-bundler-kit

pnpm add https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@6656

commit: 3eca362

Copy link

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.09%. Comparing base (6cd8dc8) to head (3eca362).
Report is 69 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6656      +/-   ##
============================================
- Coverage     58.18%   58.09%   -0.09%     
- Complexity     3774     3924     +150     
============================================
  Files           651      673      +22     
  Lines         22125    23038     +913     
  Branches       1538     1573      +35     
============================================
+ Hits          12873    13385     +512     
- Misses         8641     9035     +394     
- Partials        611      618       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2024
Copy link

f2c-ci-robot bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 46793af into halo-dev:main Sep 13, 2024
10 checks passed
@ruibaby ruibaby deleted the fix/editor-list branch September 13, 2024 11:50
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

默认编辑器的引用中的有序列表不渲染开头数字
2 participants