Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add index build state as readiness check indicator #6700

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Sep 25, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.20.x

What this PR does / why we need it:

将索引构建状态添加到就绪检测的指标中

Which issue(s) this PR fixes:

Fixes #6632

Does this PR introduce a user-facing change?

修复系统未启动完全时访问页面出错的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Sep 25, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Sep 25, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby September 25, 2024 08:55
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Sep 25, 2024
Copy link

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.20%. Comparing base (c945a94) to head (6ef5634).
Report is 24 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6700      +/-   ##
============================================
+ Coverage     58.17%   58.20%   +0.02%     
  Complexity     3947     3947              
============================================
  Files           680      681       +1     
  Lines         23262    23226      -36     
  Branches       1582     1582              
============================================
- Hits          13532    13518      -14     
+ Misses         9106     9084      -22     
  Partials        624      624              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

# http http://localhost:8090/actuator/health -pb

{
    "groups": [
        "liveness",
        "readiness"
    ],
    "status": "OUT_OF_SERVICE"
}

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2024
Copy link

f2c-ci-robot bot commented Sep 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit ca9adfc into halo-dev:main Sep 28, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望 /actuator/health 适配索引构建过程
3 participants