refactor: remove async loading logic for editor #6707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Wang <i@ryanc.cc>
f2c-ci-robot
bot
added
the
release-note
f2c-ci-robot
bot
added
the
kind/improvement
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6707 +/- ##
===========================================
Coverage 58.18% 58.18%
- Complexity 3774 3944 +170
===========================================
Files 651 679 +28
Lines 22125 23216 +1091
Branches 1538 1582 +44
===========================================
+ Hits 12873 13508 +635
- Misses 8641 9084 +443
- Partials 611 624 +13 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/area ui
/kind improvement
/milestone 2.20.x
What this PR does / why we need it:
取消异步加载默认编辑器，在之前的版本中，由于编辑器体积较大，所以做了异步加载的处理，但近期的版本中，为了让插件可以使用编辑器或者扩展编辑器，已经将编辑器依赖作为全局加载，如果这个时候还是异步加载编辑器组件的话，进入编辑页面的时候出现短暂的灰屏闪烁。
Does this PR introduce a user-facing change?