Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: exclude thumbnail directories when backup #6725

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Sep 29, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.20.x

What this PR does / why we need it:

备份时忽略缩略图目录

Which issue(s) this PR fixes:

Fixes #6717

Does this PR introduce a user-facing change?

备份时忽略缩略图目录以减少文件大小

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Sep 29, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Sep 29, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from LIlGG September 29, 2024 04:34
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Sep 29, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from wan92hen September 29, 2024 04:34
Copy link

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2024
@ruibaby
Copy link
Member

ruibaby commented Sep 29, 2024

相同的还有:#6443 (comment)

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.01%. Comparing base (982a45b) to head (9a79739).
Report is 21 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6725      +/-   ##
============================================
- Coverage     58.29%   58.01%   -0.28%     
- Complexity     3963     3976      +13     
============================================
  Files           680      696      +16     
  Lines         23338    23504     +166     
  Branches       1584     1567      -17     
============================================
+ Hits          13604    13636      +32     
- Misses         9108     9247     +139     
+ Partials        626      621       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Sep 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 875a804 into halo-dev:main Sep 29, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

建议halo备份时不要把适配图片也备份进来,会导致备份包过大,恢复备份变得困难
3 participants