-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: username length validation in user creation form is not working #6806
fix: username length validation in user creation form is not working #6806
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6806 +/- ##
=========================================
Coverage 57.03% 57.03%
Complexity 3978 3978
=========================================
Files 713 713
Lines 23992 23992
Branches 1570 1570
=========================================
Hits 13685 13685
Misses 9696 9696
Partials 611 611 ☔ View full report in Codecov by Sentry. |
What type of PR is this?
/area ui
/kind bug
/milestone 2.20.x
What this PR does / why we need it:
修复创建用户表单的用户名长度校验不生效的问题。
Does this PR introduce a user-facing change?