Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve s3link role permissions #89

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

longjuan
Copy link
Member

  1. 新建用户,仅赋予 s3link 权限
  2. 测试 关联s3文件功能是否 正常使用
    请使用 halo-dev/halo@ff7af9f 之后的版本进行测试
完善 s3link 角色权限

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 19, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wan92hen October 19, 2023 10:15
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit c79fee9 into halo-dev:main Oct 26, 2023
3 checks passed
@longjuan longjuan deleted the perf/role branch March 1, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants