Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: s3 link error when filename renaming enable #91

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix: s3 link error when filename renaming enable #91

merged 1 commit into from
Oct 26, 2023

Conversation

longjuan
Copy link
Member

fixes #90
请测试 上传时重命名文件方式 选项为非保留原文件名时，是否能正常关联s3文件
image

当上传时文件重命名功能开启时关联S3文件错误

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 19, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from minliacom and wan92hen October 19, 2023 12:33
JohnNiang
JohnNiang approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit c0fb2b1 into halo-dev:main Oct 26, 2023
@longjuan longjuan deleted the fix/link-filename branch March 1, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@minliacom minliacom Awaiting requested review from minliacom

@wan92hen wan92hen Awaiting requested review from wan92hen

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

当重命名文件方式不是保留原文件名时，关联s3文件错误
2 participants
@longjuan @JohnNiang