Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize watch task to prevent occasional connection closed exception #33

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Nov 5, 2024

What this PR does?

优化 Watch 任务偶尔会出现 connection closed 异常信息的问题

优化 Watch 任务偶尔会出现 connection closed 异常信息的问题

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 5, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen November 5, 2024 08:31
@guqing guqing requested review from JohnNiang and LIlGG and removed request for wan92hen November 5, 2024 08:31
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2024
Copy link

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 46ecbe3 into halo-sigs:main Nov 5, 2024
1 check passed
@guqing guqing deleted the refactor/watch-runner branch November 5, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants