Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add creation time field for comments and replies #14

Merged
merged 3 commits into from
Mar 30, 2023

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Feb 23, 2023

What type of PR is this?

/kind improvement

What this PR does / why we need it:

增加迁移时评论和回复的创建时间字段。适配:halo-dev/halo#3341

Which issue(s) this PR fixes:

Fixes halo-dev/halo#3330

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note-none Denotes a PR that doesn't merit a release note. labels Feb 23, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby February 23, 2023 07:13
@ruibaby ruibaby changed the title refactor: add creation time field for comments and replies WIP: refactor: add creation time field for comments and replies Feb 23, 2023
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 23, 2023
@LIlGG LIlGG changed the title WIP: refactor: add creation time field for comments and replies refactor: add creation time field for comments and replies Mar 6, 2023
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2023
Copy link

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

由于当前 PR 适配了 halo-dev/halo#3341,是否需要修改插件定义的 requires 字段来限制只允许在 2.3.0 及以上的版本运行?

@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2023
@LIlGG
Copy link
Member Author

LIlGG commented Mar 17, 2023

由于当前 PR 适配了 halo-dev/halo#3341,是否需要修改插件定义的 requires 字段来限制只允许在 2.3.0 及以上的版本运行?

确实应该限制,已进行补充。

Copy link

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2023
Copy link

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit ed1497a into halo-sigs:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

评论和回复增加允许修改的创建时间来兼容迁移顺序问题
3 participants