This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
feat: add an indentation extension to the editor #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JohnNiang
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
guqing
approved these changes
Aug 25, 2023
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot bot
pushed a commit
to halo-dev/halo
that referenced
this pull request
Aug 25, 2023
#### What type of PR is this? /area console /kind cleanup /milestone 2.9.x #### What this PR does / why we need it: 升级默认编辑器的版本,包含以下修改: 1. 图片支持修改 alt 属性。 halo-sigs/richtext-editor#32 2. 拖拽修改图片大小的时候保持等比例。 halo-sigs/richtext-editor#33 3. 优化在移动端下,编辑器右侧边栏的样式。 halo-sigs/richtext-editor#35 4. 编辑器标题、段落及代码块增加 Tab 快捷键缩进。 halo-sigs/richtext-editor#34 #### Does this PR introduce a user-facing change? ```release-note 升级默认编辑器的版本,包含以下更改: 1. 图片支持修改 alt 属性。 by @GodlessLiu in <halo-sigs/richtext-editor#32> 2. 拖拽修改图片大小的时候保持等比例。 by @GodlessLiu in <halo-sigs/richtext-editor#33> 3. 优化在移动端下,编辑器右侧边栏的样式。 by @ruibaby in <halo-sigs/richtext-editor#35> 4. 编辑器标题、段落及代码块增加 Tab 快捷键缩进。 by @LIlGG in <halo-sigs/richtext-editor#34> ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
kind/feature
Categorizes issue or PR as related to a new feature.
lgtm
Indicates that a PR is ready to be merged.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/aear editor
What this PR does / why we need it:
为编辑器中的 Head 及段落增加了 Tab 键缩进的扩展,并为代码块增加了缩进。可以使用
Tab
键进行缩进,使用Shift + Tab
组合键进行缩进回退。How to test it?
上述部分均可测试选中部分内容及光标焦点位置,查看是否符合预期。
Which issue(s) this PR fixes:
See #4447
See #4380
Does this PR introduce a user-facing change?