Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Upstream Issue 349 - tag link has double forward slash #354

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

jvincentnz
Copy link
Contributor

Fix for "#349" where "tags" have double forward slashes causing broken links.
Takes the fix from "dovidio/personalwebsite@34762e9" for "layouts/partials/post_preview.html" and extends it to also fix "layouts/_default/single.html".

@nelsonwellswku
Copy link

nelsonwellswku commented May 13, 2024

@jvincentnz the terms.html layout file needs to change for this as well. This line will also add the extra forward slash.

@jvincentnz
Copy link
Contributor Author

Updated terms.html layout file to fix the extra forward slash as per @nelsonwellswku.

@henryiii henryiii merged commit 2610147 into halogenica:master Jun 8, 2024
1 check passed
@henryiii
Copy link
Collaborator

henryiii commented Jun 8, 2024

Thanks!

@henryiii
Copy link
Collaborator

henryiii commented Jun 8, 2024

I’ll probably delete the commented version at some point if I get around to it, I think this is the correct way to do it so I don’t need a commented bad way to do it. :) Having a note is fine, just not the commented out code.

@ibnunowshad
Copy link

ibnunowshad commented Jun 8, 2024

Footer.html has some changes too?

@jvincentnz jvincentnz deleted the upstream-issues-349 branch June 9, 2024 01:48
sunpech pushed a commit to sunpech/beautifulhugo that referenced this pull request Aug 18, 2024
…ica#354)

* Fixes Upstream Issue 349 - tag link has double forward slash

* Updated fix for Upstream Issue 349 - tag link has double forward slash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants