Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] settings to get v2-all.json from another url or from a local drive #9

Open
topin89 opened this issue Jul 4, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@topin89
Copy link

topin89 commented Jul 4, 2021

Hello.

For some reason, https://cdn.wes.cloud/beatstar/bssb/v2-all.json download speed here is extremely slow, around 125 KB/s, so it takes around 7-9 minute to download the file. In the game, that means song info loads for some time and then suddenly it says info is loaded but it actually isn't.

I tried to understand what and where to change in the code to use local file, and failed. Best thing I could do is to replace the link to http://localhost/v2-all.json and set up python -m http.server 80. It works, but that's an ugly hack at best.

Can you add an option to use local file?

@WesVleuten
Copy link
Collaborator

Hi there,

I've just added GZIP support in #10 which would reduce the download from 52.83 MB to 7.24 MB. It wouldn't completely fix your issue, but it would reduce the download time by 7 times.

Once this is release, could you circle back to us about your experience then?

Thanks!

@topin89
Copy link
Author

topin89 commented Jul 21, 2021

Woah. Missed your answer, didn't expect it would be answered after four day of silence. Sure, I'll check on next release, that should be soon

@halsafar halsafar added the enhancement New feature or request label Aug 27, 2021
@halsafar halsafar self-assigned this Aug 27, 2021
@halsafar
Copy link
Owner

This might be nice for testing/benchmarking purposes. SDC could switch over to IPA Config and we can offer some config settings (like custom url).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants