fix(walk): match filesystem casing for entries on macOS #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nim 0.19.0 has been released and is now the stable version which means this PR green lights 🎉 Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32
We now use a call to
expandFilenameto get the path's casing as it exists in the filesystem. This has refactored things a bit so that instead of tracking relative paths and converting them to absolutes, we use absolutes and convert them relatives.This PR also introduces macOS testing on travis against both stable & devel versions of nim just like the linux tests. Stable Nim (< 0.19.0) on macOS will currently fail — this is because
FileSystemCaseSensitivereturnedtruefor macOS until nim-lang/Nim#8411 which is in Nim >= 0.19.0 (currently devel but soon to be stable).All this means for users is that the casing of returned filesystem entries doesn't quite match the actual filesystem — the results are otherwise correct, so I don't consider this much of a showstopper.