Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scrollability + fixed the issue of overflow - TimerEditor #133 #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vpetrovic01
Copy link

In the screen TimerEditor, scrollability has been added, and issue of overflow has been fixed. #133

overflow_fix

@12people
Copy link
Collaborator

Hi @vpetrovic01
Thanks for the PR!

Testing this out on macOS, I'm running into this issue: The following StateError was thrown building _SelectionKeepAlive(state: _SelectionKeepAliveState#0bede): Bad state: Stream has already been listened to..

To reproduce:

  1. Build under macOS (probably works for Linux too, or any platform where you can resize windows).
  2. Resize the window so that it's small enough to potentially contain only the timer description field.
  3. Visit a timer entry detail.
  4. Scroll down to the bottom of the screen.
  5. Scroll up.

(I'm thinking you can probably reproduce this error on Android or iOS by just adjusting the description box constraints — e.g. a minHeight of, say 600. I haven't tried it myself, though.)

Could you please fix this?

@vpetrovic01
Copy link
Author

Hi @12people,
Thank you for your response, I fixed the issue and made a new pull request.
Hope it works fine now!

Copy link
Owner

@hamaluik hamaluik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants