feat: add encoders to avrogen #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Schema returns the schema for {{ .Name }}. | ||
| func (o *{{ .Name }}) Schema() avro.Schema { | ||
| if o.schema == nil { | ||
| o.schema = avro.MustParse(` + "`{{ .Schema }}`" + `) |
There was a problem hiding this comment.
Is there a way to avoid parsing the schema whenever we decode a new struct? What is the cost of decoding a stream of events (in my case, more than 10K events per second), then processing and encoding them back? Also, each struct will now have an embedded schema struct, adding some memory overhead.
There was a problem hiding this comment.
Thats what this does. It caches the schema that is parsed.
There was a problem hiding this comment.
The cache seems to be in the struct level, so each time a new struct is created will have to parse the schema?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for generating encoders and the schema to all generated objects.