Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stdout output support to avrogen #302

Merged
merged 6 commits into from
Sep 6, 2023
Merged

feat: add stdout output support to avrogen #302

merged 6 commits into from
Sep 6, 2023

Conversation

hhromic
Copy link
Contributor

@hhromic hhromic commented Sep 5, 2023

Hello, this small PR adds support for stdout output to avrogen.
It is implemented by making the -o FILE argument optional, writing the generated Go code to stdout if not provided.

I updated the unit tests accordingly and fixed some wrong wording in error messages as well 👍.

The use case for this feature is quick debugging of Go structs generation without having to use temporary files.

cmd/avrogen/main.go Outdated Show resolved Hide resolved
cmd/avrogen/main.go Outdated Show resolved Hide resolved
hhromic and others added 2 commits September 5, 2023 20:57
cmd/avrogen/main.go Show resolved Hide resolved
Copy link
Member

@nrwiersma nrwiersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@nrwiersma nrwiersma merged commit 015449d into hamba:main Sep 6, 2023
2 of 3 checks passed
@hhromic hhromic deleted the avrogen-stdout branch September 6, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants